Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: deactivate dangerousExtend feature by default #519

Open
timomayer opened this issue Aug 11, 2020 · 1 comment
Open

suggestion: deactivate dangerousExtend feature by default #519

timomayer opened this issue Aug 11, 2020 · 1 comment

Comments

@timomayer
Copy link
Contributor

A few days ago i sent in a PR to make dangerousExtend available as environment varable but then i realized that does still not help in all cases because IDE implemented lint tools like eslint vscode plugin can still not be configured to use it.

Since eslint and stylelint both come with a very similar extend functionallity but both without this security feature, i vote for disabling the feature per default in browserslist to be in line with eslint and stylelint extendability.

@ai
Copy link
Member

ai commented Aug 11, 2020

Since eslint and stylelint both come with a very similar extend functionallity but both without this security feature, i vote for disabling the feature per default in browserslist to be in line with eslint and stylelint extendability.

I do no trust open source community to use ESLint and Stylelint as examples as “you should not worry about it”.

This feature was added websites like CodePen or browserl.ist. Let’s took a browserl.ist as an example. As you can see developer forget to escape extends query. I do not think that it is a developer’s mistake. If we will fix it in this website, other developers will make the same mistake on a new website.

then i realized that does still not help in all cases because IDE implemented lint tools like eslint vscode plugin can still not be configured to use it.

You can set BROWSERSLIST_DANGEROUS_EXTEND on system-level in your .bashrc config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants