Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add semver and project version query to Node and Electron #513

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ylemkimon
Copy link

@ylemkimon ylemkimon changed the title feat: add semver query to Node and Electron feat: add semver and project version query to Node and Electron Jul 24, 2020
@ai
Copy link
Member

ai commented Jul 24, 2020

What is use case?

I try to avoid adding more queries, because it is hard to maintain so many queries for me.

@ylemkimon
Copy link
Author

The major use case is deduplicating information in package.json, especially since Browserslist and semver have different version range semantics.

@ai
Copy link
Member

ai commented Jul 27, 2020

I do not like solving this problem by adding an extra query. We already have too many queries.

Maybe we need to change node X query behavior in a major version.

@ai ai added this to the 5.0 milestone Jul 27, 2020
@ai
Copy link
Member

ai commented Jul 27, 2020

We will not be able to release major version in next month because I spending all my free time on preparing PostCSS 8.

@ylemkimon
Copy link
Author

ylemkimon commented Jul 28, 2020

@ai I've added semver query as it uses the same logic with the project version query, but if it causes too much technical debt, I can remove it.

@ai
Copy link
Member

ai commented Jul 28, 2020

I am right that you have no critical issue to be fixed with this PR?

Let me finish with PostCSS 8 release process and then I will think about Node.js versions.

@ylemkimon
Copy link
Author

@ai Yes, this is just a convenience.

@ai ai changed the base branch from master to main December 1, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficult to select all versions in a major [Feature suggestion] Support package.json engines.node field
2 participants