Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAEP encryption using SHA1? #172

Open
core433 opened this issue Oct 6, 2017 · 1 comment
Open

OAEP encryption using SHA1? #172

core433 opened this issue Oct 6, 2017 · 1 comment

Comments

@core433
Copy link

core433 commented Oct 6, 2017

I've posted this issue on the public-encrypt repo as well:

browserify/publicEncrypt#13

Public Encrypt is using sha1 for the hash function, is that secure? It sounds like sha1 is being deprecated because it's been theoretically crackable since 2005. Is this the same hash function that node crypto is using / are they not on sha2 / sha256?

@dominictarr
Copy link
Contributor

yes probably but the goal here is to be fully compatible with the node crypto api, so we'll remove this when they do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants