Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for node v0.8 support #1939

Merged
merged 3 commits into from Dec 28, 2019
Merged

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Dec 28, 2019

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
kumavis and others added 2 commits December 28, 2019 11:44
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
@ljharb ljharb added the bug label Dec 28, 2019
@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

I also noticed appveyor and travis tests dont have the same engine coverage...

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

would be nice to document supported platforms for both browserify and bundles

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

also if we could turn on greenkeeper for only in-range dep updates? would give us an idea if our deps break

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

woof appveyor takes forever

@kumavis
Copy link
Contributor Author

kumavis commented Dec 28, 2019

@ljharb finished cooking

@ljharb
Copy link
Member

ljharb commented Dec 28, 2019

We should definitely make sure “engines” is set correctly, as are CI matrices.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json###

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants