New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom names for "browser" field resolution #1918
Conversation
? function (id, opts, cb) { | ||
if (!opts.basedir) opts.basedir = path.dirname(opts.filename) | ||
resolve(id, opts, cb) | ||
} | ||
: bresolve | ||
: typeof browserField === 'string' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure nobody is putting a string value now, and relying on it being a noop?
What if it's an empty string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now any value other than false
(including an empty string) just does normal "browser"
field resolution.
We've never supported any value other than false
for this argument and since this is an additive change, I'd argue it could be released in a minor version. But I'm also fine with releasing it in a major version to be extra safe, though I think it's a bit overkill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that was two questions :-) you answered the first, but not the second - after this PR, should an empty string be allowed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simplest rule would be: if the type is string
, then we look for that key in package.json
and apply the "browser" field spec.
So, then an empty string would look for an empty string key in package.json
.
But it's also likely to be a bug, so also I'm okay with throwing an exception in this case.
2af69b6
to
8213b64
Compare
@substack took a look at this and said it looks good on IRC. I'm going to merge it now. |
16.5.0 |
Fixes: #1917