New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http2 to builtins #1913
Add http2 to builtins #1913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
You're welcome. Thanks for the quick merge and release! |
It might be worth using resolve’s listing of core modules to default all of them to empty (and override with shims as needed) - then this would have Just Worked. |
that sounds like a good idea—we've had a few browserify releases lately that were mostly about adding new empty shims. |
(Pull in |
The set of core modules isn’t the same for all Node versions. We might not necessarily build and run on the same version of Node. Maybe we need an extra option to specify the target runtime, e.g. |
@steve-taylor that’s a reasonable addition to resolve if it’s needed; but i do think that building and running on the same version is typical. |
Node.js 10.10.0 added the
http2
module. This change adds just enough support for--no-builtins
(and therefore--node
) to recognisehttp2
as a Node.js built-in module and not attempt to bundle it.