Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path-browserify to v1.0.0 #1838

Merged
merged 1 commit into from Nov 15, 2019
Merged

Update path-browserify to v1.0.0 #1838

merged 1 commit into from Nov 15, 2019

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Jun 6, 2018

This version updates to the Node v10.3.0 API. This change is breaking,
because path methods now throw errors when called with arguments that are not
strings.

  • Add path.parse and path.format.
  • Add path.posix as an alias to path.
  • Port tests from Node.js.

One for v17, maybe. path.XYZ(undefined) throwing an error is definitely going
to break existing projects. I guess they could just stay on older browserify
versions tho.

Closes #1846

@goto-bus-stop goto-bus-stop changed the title Update path-browserify to v1 Update path-browserify to v1.0.0 Jun 6, 2018
@ChALkeR
Copy link

ChALkeR commented Jun 9, 2018

Eh, I hoped this update could get in as a semver-minor version…
Any ETA for the release?

I will probably take a look if fixes could be backported to path-browserify@0.0.x.
@goto-bus-stop What do you think?

@ChALkeR
Copy link

ChALkeR commented Jun 9, 2018

path methods now throw errors when called with arguments that are not
strings.

Do you have a specific case in mind, btw?

That's not applicable to all the methods, as e.g. "

  • path.resolve threw on non-strings in 0.0.0.
  • path.isAbsolute also likely threw as it called .charAt directly without any checks.
  • path.normalize called .isAbsolute and also threw.
  • path.join also contained a check.
  • path.relative called .resolve and also threw.

The three methods that didn't throw were: .dirname(), .basename() and .extname().

What do you think of converting the input to string on those and releasing that as path-browserify@0.0.1?

@goto-bus-stop
Copy link
Member Author

The basename / extname / dirname methods didn't throw in 0.0.0:

image

I think doing a path-browserify release with the fixes and new features but without the additional checks would be fine…

@ChALkeR
Copy link

ChALkeR commented Jun 9, 2018

@goto-bus-stop Could I chat with you via IRC or Gitter about it?

@niftylettuce
Copy link

Hey folks just wanted to reach out and see if there's anything I can do to help here

@ChALkeR
Copy link

ChALkeR commented Jun 25, 2018

For posterity: my concerns above were adressed with a semver-patch version of path-browserify@0.x that backported some of the fixes in a compatible form, so having this update to @1.0.0 a semver-major is fine to me.

Copy link

@vetqa0-gorzup-sYqwuv vetqa0-gorzup-sYqwuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ ]

@vetqa0-gorzup-sYqwuv
Copy link

  • __

Copy link

@vetqa0-gorzup-sYqwuv vetqa0-gorzup-sYqwuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

bump path-browserify version to latest (1.0.0)
4 participants