New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update path-browserify to v1.0.0 #1838
Conversation
Eh, I hoped this update could get in as a semver-minor version… I will probably take a look if fixes could be backported to |
Do you have a specific case in mind, btw? That's not applicable to all the methods, as e.g. "
The three methods that didn't throw were: What do you think of converting the input to string on those and releasing that as |
@goto-bus-stop Could I chat with you via IRC or Gitter about it? |
Hey folks just wanted to reach out and see if there's anything I can do to help here |
For posterity: my concerns above were adressed with a semver-patch version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version updates to the Node v10.3.0 API. This change is breaking,
because path methods now throw errors when called with arguments that are not
strings.
path.parse
andpath.format
.path.posix
as an alias topath
.One for v17, maybe.
path.XYZ(undefined)
throwing an error is definitely goingto break existing projects. I guess they could just stay on older browserify
versions tho.
Closes #1846