New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for problems introduced in ~resolve@1.1.5 and fixed in resolve@1.1.6 #1139
Tests for problems introduced in ~resolve@1.1.5 and fixed in resolve@1.1.6 #1139
Conversation
975a3a2
to
7a16a7d
Compare
After rebasing tests now pass - I assume the tests are still worth merging into the suite? |
I suppose this is not going in. |
It’d be great if this went in. |
@dominykas i know this is old, but if you could rebase it, I’d love to see it go in. It will help ensure that resolve doesn’t break behavior in browserify. |
OK, I'll see what I can do. |
…rmally do, i.e. with/without extension and directories should fall back to index, and index from a directory should be accepted with/without extension too
f6d6728
to
f13b713
Compare
I've no recollection of details of what happened there, but let's see if rebasing makes the tests pass :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More tests, tests that pass, I'm not seeing a downside
When a module is exposed, it should still resolve the way it would normally do, i.e. with/without extension and directories should fall back to index, and index from a directory should be accepted with/without extension too.In this PR there are the tests that will fail - I am not able to run them reliably for some reason, so withresolve@1.1.5
they simply hang, however they will pass if younpm install resolve@1.1.2
I'm not sure how to make them pass - that, I believe, belongs in theresolve
module - I'll create a relevant issue there, mostly because I've no idea how things are wired up.The following tests are added, where
x
is a file andy
is a folder with anindex.js
inside:b.require('./x', {expose: 'xyz'});
b.require('./y', {expose: 'xyz'});
b.require('./y/index', {expose: 'xyz'});
b.require('./y/index.js', {expose: 'xyz'});