Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codemodder: remove context argument of Field.from_db_value() and Expression.convert_value() #116

Open
browniebroke opened this issue Jun 19, 2020 · 0 comments
Open

Codemodder: remove context argument of Field.from_db_value() and Expression.convert_value() #116

browniebroke opened this issue Jun 19, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
Django 3.0

Comments

@browniebroke
Copy link
Owner

browniebroke commented Jun 19, 2020 •
edited

Description

From Django 2.0 release notes:

The context argument of Field.from_db_value() and Expression.convert_value() is unused as it’s always an empty dictionary.

The signature of both methods is now:

(self, value, expression, connection)

instead of:

(self, value, expression, connection, context)

We could probably update the usages of these methods.

This is removed in Django 3.0.
@browniebroke browniebroke added the enhancement New feature or request label Jun 19, 2020
@browniebroke browniebroke added this to the Django 3.0 milestone Sep 20, 2020
@browniebroke browniebroke changed the title Remove context argument of Field.from_db_value() and Expression.convert_value() Codemodder: remove context argument of Field.from_db_value() and Expression.convert_value() Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Django 3.0
Development

No branches or pull requests
1 participant
@browniebroke