Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer able to override mimetype #157

Closed
hikirsch opened this issue May 11, 2017 · 2 comments · May be fixed by jmardjuki/beatboxer#2, bihtyu/node.js-demo#3 or bihtyu/node.js-demo#4
Closed

no longer able to override mimetype #157

hikirsch opened this issue May 11, 2017 · 2 comments · May be fixed by jmardjuki/beatboxer#2, bihtyu/node.js-demo#3 or bihtyu/node.js-demo#4

Comments

@hikirsch
Copy link

hikirsch commented May 11, 2017

It seems in the last 1.3.5 push, there's a new continue when detecting an existing mime type thus no longer allowing to override the content type.
https://github.com/broofa/node-mime/blob/master/mime.js#L43

This is has been the solution for so long
angular/angular-cli#2125 (comment)

This breaks all of our builds right now and I would hope that this would break the semantic versioning of the project and would be consider to be a major change.

Can we please unpublish 1.3.5 from npm?

@hikirsch
Copy link
Author

it seems for now i can specifically install version 1.3.4 in my package.json my karma tests will still run

@broofa broofa closed this as completed in 29f5a46 May 12, 2017
@broofa
Copy link
Owner

broofa commented May 12, 2017

Reverted facet commit (902ec07) and published as v1.3.6. Deprecated v1.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants