Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #9

Merged
merged 7 commits into from
Jul 27, 2018
Merged

New features #9

merged 7 commits into from
Jul 27, 2018

Conversation

krisselden
Copy link
Contributor

@krisselden krisselden commented Jun 15, 2018

Adds new features that help with testing edge cases, like binary files or tracking changes outside of build output.

Clarify public api and add api documentation.

@krisselden krisselden changed the title New features WIP New features Jul 26, 2018
Copy link
Contributor

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the wrapDir functionality, I left some thoughts on the naming above.

Another Q I have is should we provide an API that allows for a combination of wrapDir and fixturify?

Something like:

fromDirectory('foo', {
   // overrides
});

src/index.ts Outdated
*
* @public
*/
export function wrapDir(dir: string): t.ReadableDir {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just spit-balling, what about fromDir or similar instead of wrapDir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this api isn't new, I could do that and deprecate wrap versions, I do like from better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you also like it better, lets transition to fromDir.

@krisselden
Copy link
Contributor Author

krisselden commented Jul 27, 2018

@stefanpenner not sure what you

fromDirectory('foo', {
   // overrides
});

to do, fromDir doesn't do anything but adapt it to the interface, doesn't process the directory until you try to read the directory itself.

As for mutation, the intention is you copy from a fixture to a tmp dir, this only returns a read only interface, the tmp dir has all the writing methods.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Thanks for working on this!

@stefanpenner stefanpenner merged commit 01605b2 into master Jul 27, 2018
@stefanpenner
Copy link
Contributor

released as v1.4.0 🎉

@stefanpenner stefanpenner deleted the new-features branch July 27, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants