-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features #9
New features #9
Conversation
Add test coverage for new features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the wrapDir functionality, I left some thoughts on the naming above.
Another Q I have is should we provide an API that allows for a combination of wrapDir
and fixturify
?
Something like:
fromDirectory('foo', {
// overrides
});
src/index.ts
Outdated
* | ||
* @public | ||
*/ | ||
export function wrapDir(dir: string): t.ReadableDir { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just spit-balling, what about fromDir
or similar instead of wrapDir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this api isn't new, I could do that and deprecate wrap versions, I do like from better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you also like it better, lets transition to fromDir
.
Documentation fixes.
@stefanpenner not sure what you
to do, fromDir doesn't do anything but adapt it to the interface, doesn't process the directory until you try to read the directory itself. As for mutation, the intention is you copy from a fixture to a tmp dir, this only returns a read only interface, the tmp dir has all the writing methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Thanks for working on this!
released as v1.4.0 🎉 |
Adds new features that help with testing edge cases, like binary files or tracking changes outside of build output.
Clarify public api and add api documentation.