Skip to content

"is404" remains true #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hamedg68 opened this issue Mar 5, 2023 · 3 comments
Closed

"is404" remains true #681

hamedg68 opened this issue Mar 5, 2023 · 3 comments
Labels

Comments

@hamedg68
Copy link

hamedg68 commented Mar 5, 2023

Description

is404 in pageContext remains true if onBeforeRender is not provided for the page. here is the reproduction from vue-full example for this issue which shows if we are in 404NotFound page and we want to go to Welcome and Markdown page, is404 property remains true but for Data Fetching and Routing page which have onBeforeRender
is404 is updated

https://stackblitz.com/github/hamedg68/VPS-vue-full-is404

Error Message + Error Stack

is404 not updated

@brillout
Copy link
Member

brillout commented Mar 5, 2023

Indeed, I could reproduce. I'll have a look at it. It's most likely due to the Vue integration at renderer/, let's see.

@brillout
Copy link
Member

brillout commented Mar 5, 2023

Fix released in v0.4.91.

@brillout brillout closed this as completed Mar 5, 2023
@brillout
Copy link
Member

brillout commented Mar 5, 2023

Going back to the 404 page now works.

Note that is404 still remains true in your example because of the Vue integration.

AFAICT VPS itself hasn't any bug left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants