Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve international character support in slugify #67

Closed
jaredcwhite opened this issue Jun 3, 2020 · 1 comment · Fixed by #138
Closed

Improve international character support in slugify #67

jaredcwhite opened this issue Jun 3, 2020 · 1 comment · Fixed by #138
Assignees
@jaredcwhite
Labels
bug Something isn't working enhancement New feature or request
Milestone
0.17.0 "Mount Scott"

Comments

@jaredcwhite
Copy link
Member

While we're not routinely tracking low-level Jekyll improvements at this point, occasionally something might catch my eye and this is one of them:

jekyll/jekyll#8167

Seems like something important to improve here as well.
@jaredcwhite jaredcwhite added the bug Something isn't working label Jun 3, 2020
@jaredcwhite jaredcwhite added this to the 0.16.0 "Crystal Springs" milestone Jun 19, 2020
@KonnorRogers
Copy link
Member

KonnorRogers commented Jul 9, 2020 •
edited

I'm all for additional i18n support. I'll take a look at the Jekyll PR and see if it could be simply dropped into Bridgetown.

I also don't think there's enough people using Bridgetown to worry about extreme-edge cases where URLs May change as mentioned in the Jekyll issue.

@KonnorRogers KonnorRogers self-assigned this Jul 9, 2020
@KonnorRogers KonnorRogers added the enhancement New feature or request label Jul 9, 2020
@jaredcwhite jaredcwhite removed this from the 0.16.0 "Crystal Springs" milestone Jul 24, 2020
@jaredcwhite jaredcwhite added this to the 0.17.0 "TBD" milestone Sep 3, 2020
@jaredcwhite jaredcwhite mentioned this issue Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredcwhite jaredcwhite

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
0.17.0 "Mount Scott"
Development

Successfully merging a pull request may close this issue.

Add international character slug improvements by Matt Swanson bridgetownrb/bridgetown
2 participants
@jaredcwhite @KonnorRogers