Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring no longer builds with Rust 1.61 due to cc dependency #2035

Closed
uweigand opened this issue Apr 23, 2024 · 1 comment
Closed

Ring no longer builds with Rust 1.61 due to cc dependency #2035

uweigand opened this issue Apr 23, 2024 · 1 comment

Comments

@uweigand
Copy link
Contributor

As of cc 1.0.95, the minimum required Rust version is 1.63: rust-lang/cc-rs#1031

However, the Ring CI still attempts to build with 1.61, which now fails with:

error: package `cc v1.0.95` cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.61.0

We should either increase the minimum required Rust level for Ring as well, or else force use of an older cc version.

@briansmith
Copy link
Owner

We should either increase the minimum required Rust level for Ring as well, or else force use of an older cc version.

The user of ring could already force an older cc-rs version if they want to, using their Cargo.lock. However, I updated the MSRV of ring to 1.63 in PR #2037 so that I don't have to add any complication to the GitHub Actions configuration regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants