Added option to do entity encoding #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also take care of the |
Ah, yes we should |
tenderlove
reviewed
Jul 23, 2018
ext/yajl/yajl_encode.c
Outdated
| @@ -76,10 +82,39 @@ yajl_string_encode2(const yajl_print_t print, | |||
| case '\b': escaped = "\\b"; break; | |||
| case '\t': escaped = "\\t"; break; | |||
| case '/': | |||
| if (htmlSafe) { | |||
| if (htmlSafe == 1) { | |||
There was a problem hiding this comment.
Lets change this to htmlSafe == 1 || htmlSafe == 2 to address @rafaelfranca's comment
This adds a feature to support entity encoding to escape characters that can be used XSS attacks. This is to match the behavior in ActiveSupport::JSON. The purpose of matching AS::JSON behavior is so we can replace it with Yajl so we can use the faster version. Co-authored-by: Aaron Patterson <aaron.patterson@gmail.com>
eileencodes
force-pushed
the
escape-entities
branch
from
7b5ba28
to
8d0a552
Compare
|
I added support for encoding slashes and force pushed 👍 |
rafaelfranca
approved these changes
Jul 27, 2018
|
Thanks @eileencodes and @tenderlove! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature to support entity encoding to escape characters that
can be used XSS attacks. This is to match the behavior in
ActiveSupport::JSON. The purpose of matching AS::JSON behavior is so we
can replace it with Yajl so we can use the faster version.
Worked on this with @tenderlove to add the same support we have in ActiveSupport::JSON
cc/ @rafaelfranca @jeremy
cc/ @brianmario