Fix some errors #183
Merged
Fix some errors #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
force-pushed
the
fix-some-errors
branch
from
2ef2a03
to
08d9b5f
Compare
If something besides an object or array is passed to the parser, it will
raise an exception and the lexer isn't free'd. This patch moves the
token checks up a little so that we can free the lexer before raising an
exception.
This program will leak memory without bounds:
```ruby
require 'yajl'
loop do
begin
stream = StringIO.new('foo')
projector = Yajl::Projector.new(stream)
projector.project({"name" => nil})
rescue Yajl::ParseError
end
end
```
This commit removes token type check duplication. Before this commit, all callers of `rb_yajl_projector_filter` would do the same token type checks that the body of the function would do. This commit simply pushes the type checks down to the body of the function.
The simple value de-serialization method seems to be missing some branches in its switch statement. This adds a missing branch
This program would exhibit unbounded memory growth:
```ruby
loop do
begin
stream = StringIO.new('[,,,,,]')
projector = Yajl::Projector.new(stream)
projector.project({"name" => nil})
rescue Yajl::ParseError
end
end
```
This patch fixes it
The projection parser should raise the same exceptions that the regular JSON parser raises when parsing a bad document
tenderlove
force-pushed
the
fix-some-errors
branch
from
08d9b5f
to
1e50529
Compare
keithduncan
reviewed
Dec 18, 2017
|
|
||
| VALUE val = rb_yajl_projector_filter(parser, key_schema, value_event); | ||
|
|
||
| rb_str_freeze(key); |
| (VALUE)args, | ||
| &state); | ||
| } else { | ||
| yajl_lex_free(parser.lexer); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some of the errors I saw in @keithduncan's branch. I included the key freeze optimization, but none of the other optimizations I mentioned.