Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why the archive streaming support will be deprecated in 2.0? #181

Open
noraj opened this issue Dec 4, 2017 · 3 comments
Open

Comments

@noraj
Copy link

noraj commented Dec 4, 2017

Why the archive streaming support will be deprecated in 2.0?

See https://github.com/brianmario/yajl-ruby/blob/master/CHANGELOG.md#100-september-13th-2011

@semaperepelitsa
Copy link

Would like to know the reason behind deprecations as well, considering Readme still recommends using them 🙂

@kyrofa
Copy link

kyrofa commented Mar 5, 2024

These were introduced in 3127064, which also contains no context. @brianmario can you help us out, here? It's unclear what we should be using.

@brianmario
Copy link
Owner

Hey everyone, so sorry on the delay. I'm very rarely on GitHub these days.

So full disclosure this was my first big OSS project. And at the time (September of 2011) I was adding as many features as I could in order to help adoption - which apparently worked ;)

Over the years as I matured as an engineer, I came to realize that reducing the scope of the library would make maintenance a lot easier. My plan was to move those APIs into an "example" folder (or something) from which a caller could basically copy/paste that code into their own project if they wanted it. The streaming APIs aren't doing anything special or magic that couldn't be dropped in another codebase.

I had a similar revelation with mysql2, after which I co-wrote Trilogy. For reasons I outline here.

I had plans to move this project to the underlying yajl 2.x branch, but I didn't do a great job of keeping track of my changes to the yajl library itself. The yajl 2.x branch diverged quite a bit from my heavily modified yajl 1.x branch I had embedded in this codebase. I made some pretty good progress in the 2.0 branch but there are still missing features in yajl 2.x itself that held me back from fully moving to it. So it stalled out and I have been away from OSS work since around 2018.

I'm not sure when I'll have any time to help wrap up the 2.0 branch, if ever. Sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants