Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show colors in Windows CMD & Powershell #138

Merged
merged 1 commit into from Apr 22, 2022
Merged

Do not show colors in Windows CMD & Powershell #138

merged 1 commit into from Apr 22, 2022

Conversation

Navusas
Copy link
Contributor

@Navusas Navusas commented Apr 1, 2022

What
Does not show colors in simple Windows CMD or Powershell shells

Why
Before, even when using White color, you would get some random characters representing the colors

Something like:
[37m <spinner-here> [21m

How has this been tested
I made the change and locally imported the package into the new solution which creates the spinner and sleeps for 10s.
Then I run it on:

  • CMD
  • Powershell
  • Windows Terminal (Powershell)
  • Windows Terminal [Ubuntu] to ensure that it works on all of them.

@Navusas
Copy link
Contributor Author

Navusas commented Apr 11, 2022

Hey,
Can this be reviewed please?

Thanks,

@briandowns
Copy link
Owner

Hey, been traveling... Will review when I have a moment to do so.

@briandowns briandowns merged commit 8c5f2aa into briandowns:master Apr 22, 2022
briandowns added a commit that referenced this pull request Apr 22, 2022
briandowns added a commit that referenced this pull request Apr 22, 2022
@briandowns
Copy link
Owner

Merged and reverted due to the runtime call. Please feel free to fix it and resubmit the PR.

@Navusas
Copy link
Contributor Author

Navusas commented Apr 22, 2022

Thanks for reviewing.

Also, sorry for a typo. I don't know how go build didn't throw me any errors about it.

I have made the change (changed OSOS -> GOOS) and created a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants