Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HikariCP 4 fails to be resolved in Gradle #1725

Closed
zml2008 opened this issue Jan 24, 2021 · 3 comments · Fixed by octawizard/padles-api#32, enonic/lib-sql#28, navikt/fplos#871 or navikt/fptilbake#1253

Comments

@zml2008
Copy link

zml2008 commented Jan 24, 2021

It seems like HikariCP 4 is not properly resolved due to a missing slf4j.version property.

This has come up from a renovate PR bumping the HikariCP version to 4.0.0.

The relevant line in the build log is (GH Actions log link):

 * What went wrong:
Execution failed for task ':impl-blocks:hikari-config:compileJava'.
> Could not resolve all files for configuration ':impl-blocks:hikari-config:compileClasspath'.
   > Could not find org.slf4j:slf4j-api:${slf4j.version}.
     Required by:
         project :impl-blocks:hikari-config > com.zaxxer:HikariCP:4.0.0

This might be a limitation due to Gradle's pom resolution not supporting some of the more niche features of Maven's artifact descriptor (since it appears the slf4j.version property is defined only in profiles in the pom) -- unfortunately I don't have any maven projects left to test in.

@dharrigan
Copy link
Contributor

dharrigan commented Jan 25, 2021

Hi,

This is happening too when pulling in the updated dependency with deps.edn (used by clj to resolve dependencies within a Clojure project).

Switching to HikariCP 4.0.0 now results in:

user=> SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#noProviders for further details.
SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions prior to 1.8.
SLF4J: Ignoring binding found at [jar:file:/home/david/.m2/repository/ch/qos/logback/logback-classic/1.2.3/logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#ignoredBindings for an explanation.

Reverting back to HikariCP 3.4.5, log messages are once again echoed out.

@brettwooldridge
Copy link
Owner

@dharrigan @zml2008 Fix coming momentarily.

@brettwooldridge
Copy link
Owner

Fixed, release publishing in ~30min.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment