Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features: add heartbeat to keepalive connection if configure it #1699

Merged
merged 7 commits into from Jan 12, 2021

Conversation

cadeeper
Copy link
Contributor

Add heartbeat to keepalive the connection if user configure it. It is more useful then maxLifetime in some situation.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #1699 (626c4fb) into dev (d9983b3) will increase coverage by 0.31%.
The diff coverage is 67.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1699      +/-   ##
============================================
+ Coverage     70.28%   70.60%   +0.31%     
- Complexity      564      574      +10     
============================================
  Files            26       26              
  Lines          2117     2150      +33     
  Branches        296      303       +7     
============================================
+ Hits           1488     1518      +30     
+ Misses          484      483       -1     
- Partials        145      149       +4     
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/zaxxer/hikari/HikariConfig.java 76.61% <40.00%> (-1.07%) 126.00 <2.00> (+2.00) ⬇️
...rc/main/java/com/zaxxer/hikari/pool/PoolEntry.java 89.28% <66.66%> (-2.72%) 24.00 <1.00> (+2.00) ⬇️
...c/main/java/com/zaxxer/hikari/pool/HikariPool.java 81.78% <91.66%> (+0.42%) 62.00 <2.00> (+3.00)
.../main/java/com/zaxxer/hikari/util/PropertyElf.java 87.69% <0.00%> (+0.39%) 23.00% <0.00%> (+1.00%)
...ain/java/com/zaxxer/hikari/util/ConcurrentBag.java 74.46% <0.00%> (+1.06%) 40.00% <0.00%> (+1.00%)
src/main/java/com/zaxxer/hikari/pool/PoolBase.java 72.42% <0.00%> (+2.16%) 55.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9983b3...626c4fb. Read the comment docs.

src/main/java/com/zaxxer/hikari/HikariConfig.java Outdated Show resolved Hide resolved
src/main/java/com/zaxxer/hikari/HikariConfig.java Outdated Show resolved Hide resolved
src/main/java/com/zaxxer/hikari/HikariConfig.java Outdated Show resolved Hide resolved
src/main/java/com/zaxxer/hikari/HikariConfig.java Outdated Show resolved Hide resolved
src/test/java/com/zaxxer/hikari/mocks/StubConnection.java Outdated Show resolved Hide resolved
src/main/java/com/zaxxer/hikari/pool/PoolEntry.java Outdated Show resolved Hide resolved
src/test/java/com/zaxxer/hikari/mocks/StubConnection.java Outdated Show resolved Hide resolved
@cadeeper
Copy link
Contributor Author

cadeeper commented Jan 8, 2021

Thanks for your review.I've learned a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants