Refine JMX ObjectName

[quaff]

fix #1678

[codecov]

Codecov Report

Merging #1681 (1738aaf) into dev (d9983b3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #1681      +/-   ##
============================================
+ Coverage     70.28%   70.33%   +0.04%     
- Complexity      564      565       +1     
============================================
  Files            26       26              
  Lines          2117     2120       +3     
  Branches        296      297       +1     
============================================
+ Hits           1488     1491       +3     
  Misses          484      484              
  Partials        145      145              

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/com/zaxxer/hikari/pool/PoolBase.java	70.58% <100.00%> (+0.32%)	55.00 <0.00> (+1.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9983b3...1738aaf. Read the comment docs.

[brettwooldridge]

@bo0ts I like this change, however, in its current form it will break existing users. I suggest enabling the new behavior via a system property, hikaricp.jmx.register2.0 (eg. -Dhikaricp.jmx.register2.0=true).

[quaff]

@bo0ts I like this change, however, in its current form it will break existing users. I suggest enabling the new behavior via a system property, hikaricp.jmx.register2.0 (eg. -Dhikaricp.jmx.register2.0=true).

It's too conservative, I don't think it will break any critical function.

[brettwooldridge]

@quaff Wouldn't this change break how lookups are performed?

MBeanServer mBeanServer = ManagementFactory.getPlatformMBeanServer();
ObjectName poolName = new ObjectName("com.zaxxer.hikari:type=Pool (foo)");
HikariPoolMXBean poolProxy = JMX.newMXBeanProxy(mBeanServer, poolName, HikariPoolMXBean.class);

Any existing code performing programatic lookups seems like it would surely be broken.

[quaff]

@quaff Wouldn't this change break how lookups are performed?

MBeanServer mBeanServer = ManagementFactory.getPlatformMBeanServer();
ObjectName poolName = new ObjectName("com.zaxxer.hikari:type=Pool (foo)");
HikariPoolMXBean poolProxy = JMX.newMXBeanProxy(mBeanServer, poolName, HikariPoolMXBean.class);

Any existing code performing programatic lookups seems like it would surely be broken.

I mean rare projects will lookup it directly by code.

[brettwooldridge]

@quaff HikariCP has millions of users, literally. "Rare" in this case could be thousands of users. One of those "users" could easily be Spring Boot, the Play framework, or Oracle Cloud, all of which use HikariCP and in turn have millions of users of their own.

[quaff]

@quaff HikariCP has millions of users, literally. "Rare" in this case could be thousands of users. One of those "users" could easily be Spring Boot, the Play framework, or Oracle Cloud, all of which use HikariCP and in turn have millions of users of their own.

Updated according to your suggestion.