New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update module-info to mark optional dependencies as 'static' #1582
Comments
Same issue on Java 14, using HikariCP 3.4.5 |
@prashantbhat @smironov Can one of you send a pull request? |
Opened PR #1587 with an update to latest Slf4J to use it's correct module name. Please review. |
@brettwooldridge any chance of getting this merged and released? |
Is there any workaround for this error? |
It's December, and still no one is close? |
@prashantbhat Thanks for the update but I still has the same error I work on a project using JAVA 11, MAVEN and JAVAFX13. module-info.java looks like :
I tried to add requires com.zaxxer.hikari.metrics but I got this : com.zaxxer.hikari.metrics cannot be resolved to a module Please, any idea ? |
Downgrading to 2.4.7 works for me
|
Hello ! @brettwooldridge Thanks, |
After updating to the release version 3.4.5, I get the following error. (using Java 11)
The
module-info
(release 3.4.5) defines following dependencies withrequires
directive:For HikariCP, these dependencies are optional, as in the pom.xml.
Adding the
static
modifier makes them optional, as defined in java.lang.module package summarySo, it will be very useful if these dependencies are changed to be
static
. Thanks.The text was updated successfully, but these errors were encountered: