Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle short in PropertyElf #1581

Merged

Conversation

freafrea
Copy link
Contributor

When the dataSource class has a method setX(short Y) then PropertyElf did not handle this case. Added similarly to int/long/boolean handling. Added tests.

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #1581 into dev will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1581      +/-   ##
============================================
+ Coverage     70.11%   70.14%   +0.02%     
- Complexity      561      562       +1     
============================================
  Files            26       26              
  Lines          2118     2120       +2     
  Branches        296      297       +1     
============================================
+ Hits           1485     1487       +2     
  Misses          487      487              
  Partials        146      146              
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/zaxxer/hikari/util/PropertyElf.java 87.69% <100.00%> (+0.39%) 23.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a28f6e...e18d95c. Read the comment docs.

@freafrea
Copy link
Contributor Author

Hi, is there something that I should do, so you could merge this? :)

@johnou
Copy link
Contributor

johnou commented Sep 3, 2020

@freafrea which datasource method are you invoking which uses short?

@freafrea
Copy link
Contributor Author

freafrea commented Sep 3, 2020

I have a jdbc driver in which setPort has signature void setPort(short port). It is an old one, but I still have to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants