Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HikariConfig#setInitializationFailTimeout javadoc seems wrong. #1126

Closed
jezovuk opened this issue Mar 29, 2018 · 2 comments
Closed

HikariConfig#setInitializationFailTimeout javadoc seems wrong. #1126

jezovuk opened this issue Mar 29, 2018 · 2 comments

Comments

@jezovuk
Copy link

jezovuk commented Mar 29, 2018

Environment

HikariCP version: 2.7.8

Problem description

If I understand the behavior correctly, there is an error in the javadoc for HikariConfig.setInitializationFailTimeout(); more specifically, the section describing behavior for negative timeout value:

A value less than zero will <i>not</i> bypass any connection attempt and
validation during startup, and therefore the pool will start immediately.  The
pool will continue to try to obtain connections in the background. This can mean
that callers to {@code DataSource#getConnection()} may encounter exceptions.

It is my understanding that if timeout is less than zero connection initialization and validation during startup will be bypassed, so the <i>not</i> part should be removed.

@brettwooldridge
Copy link
Owner

You are correct. Will fix.

@jezovuk
Copy link
Author

jezovuk commented Mar 29, 2018

👍

kollstrom pushed a commit to kollstrom/HikariCP that referenced this issue Feb 4, 2021
kollstrom pushed a commit to kollstrom/HikariCP that referenced this issue Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants