Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to KSP #444

Open
papjul opened this issue Sep 3, 2023 · 1 comment
Open

Migrate to KSP #444

papjul opened this issue Sep 3, 2023 · 1 comment
Labels
Priority: low Issues that have one or more workarounds available, or fall a bit outside the scope of a weather app Technical Technical changes request

Comments

@papjul
Copy link
Collaborator

papjul commented Sep 3, 2023

Quoting docs:

KSP (Kotlin Symbol Processing) is a Kotlin-first alternative to kapt. KSP analyzes Kotlin code directly, which is up to 2x faster. It also has a better understanding of Kotlin's language constructs.

Kapt is now in maintenance mode, and we recommend migrating from kapt to KSP wherever possible. In most cases, this migration only requires changes to your project's build configuration.

Dagger 2.48 introduced KSP support as alpha feature.
Hilt has support for KSP since 1.1.0: https://developer.android.com/jetpack/androidx/releases/hilt#1.1.0-alpha01

Given we only use a small subset of features of Dagger/Hilt, I believe we can start using it when it’s released as beta. Follow google/dagger#4180 first before migrating

@papjul papjul added the Technical Technical changes request label Sep 3, 2023
@papjul papjul added the Priority: low Issues that have one or more workarounds available, or fall a bit outside the scope of a weather app label Apr 14, 2024
@papjul
Copy link
Collaborator Author

papjul commented Apr 14, 2024

Low priority as there seems to be concerning performance issues. Might as well switch to a different lib than Dagger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: low Issues that have one or more workarounds available, or fall a bit outside the scope of a weather app Technical Technical changes request
Projects
None yet
Development

No branches or pull requests

1 participant