Incorrect logic in valid? method

[hallmatt]

The valid? method on a batch seems to have incorrect logic.

I specifically ran into an issue invalidating batches since the valid? method always returns false due to an integer now being returned by Redis#exists(key). resque/redis-namespace#195

sidekiq-batch/lib/sidekiq/batch.rb

Line 133 in e1cdc03

valid = !Sidekiq.redis { |r| r.exists("invalidated-bid-#{batch.bid}") }

Seems like changing this line in the valid? method would work:

valid = !Sidekiq.redis { |r| r.exists("invalidated-bid-#{batch.bid}") }

to

valid = Sidekiq.redis { |r| r.exists?("invalidated-bid-#{batch.bid}") } > 0

I ran into this with the following example, working to invalidate jobs within a batch. Here's an example job:

class Imports::Payments::ChunkJob < Imports::ChunkBase
  include Sidekiq::Job

  def perform(opts)
    return unless valid_within_batch?
  end
end

I run the batch to get things started and I expect the batch to fully run, but valid_within_batch? always returns false. I threw a debugger in the job and found the following:

(ruby) Sidekiq.redis { |r| r.exists("invalidated-bid-#{batch.bid}") }
0 
(ruby) !Sidekiq.redis { |r| r.exists("invalidated-bid-#{batch.bid}") }
false 

[github-actions]

Stale issue message