Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Tests #148

Open
fallaciousreasoning opened this issue Oct 26, 2022 · 5 comments
Open

Regression Tests #148

fallaciousreasoning opened this issue Oct 26, 2022 · 5 comments
Assignees

Comments

@fallaciousreasoning
Copy link
Collaborator

fallaciousreasoning commented Oct 26, 2022

Maybe we should add some tests which run before each deploy:

  • Validate sources.global.json (Check duplicates, Check sources count)
  • The format can be parsed by the current Brave production build
  • We don't remove any cover_urls/background_colors/favicon_urls (though they can change)
  • We don't have any duplicates
  • How many publishers_id total are there, how many removed, how many added? ~~
@aurangzaib048 aurangzaib048 self-assigned this Nov 1, 2022
@aurangzaib048
Copy link
Member

Please add here if I missed any test in the above list. @petemill

@mattmcalister
Copy link
Collaborator

@aurangzaib048 is this work done? please link to the PRs here and close this issue.

@aurangzaib048
Copy link
Member

@mattmcalister It is partially done that’s why I haven’t closed this.

I have strikethrough the bullet point which are done.

@LorenzoMinto
Copy link
Member

What's the status of this issue?

@aurangzaib048
Copy link
Member

This is paused. No progress on the 2 regression tests which are not cross out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants