Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests crash in Debug builds #38325

Closed
bridiver opened this issue May 14, 2024 · 0 comments · Fixed by brave/brave-core#23657
Closed

Tests crash in Debug builds #38325

bridiver opened this issue May 14, 2024 · 0 comments · Fixed by brave/brave-core#23657
Labels
dev-concern QA/No release-notes/exclude tests
Milestone
1.68.x - Nightly

Comments

@bridiver
Copy link
Contributor

bridiver commented May 14, 2024 •
edited

There is a NDEBUG check triggered by brave::RegisterPathProvider because we are registering the brave paths multiple times. Also they should be registered as part of the test setup just like chrome::RegisterPathProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern QA/No release-notes/exclude tests
Projects
None yet
Milestone
1.68.x - Nightly
Development

Successfully merging a pull request may close this issue.

Browser test fixes brave/brave-core
2 participants
@bridiver @brave-builds