Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in BraveNewsPreferencesTypeAdapter #38267

Closed
SergeyZhukovsky opened this issue May 13, 2024 · 0 comments · Fixed by brave/brave-core#23635
Closed

Crash in BraveNewsPreferencesTypeAdapter #38267

SergeyZhukovsky opened this issue May 13, 2024 · 0 comments · Fixed by brave/brave-core#23635
Assignees
Labels
crash feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash on GPC on nightly v1.68.6. It's fine to fix it in master only as there are not a significant amount of them.

Exception java.lang.NullPointerException: Attempt to invoke interface method 'int java.util.List.size()' on a null object reference
  at org.chromium.chrome.browser.settings.BraveNewsPreferencesTypeAdapter.getItemCount (BraveNewsPreferencesTypeAdapter.java:420)
  at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep1 (RecyclerView.java:4545)
  at androidx.recyclerview.widget.RecyclerView.onMeasure (RecyclerView.java:4011)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at android.widget.LinearLayout.measureChildBeforeLayout (LinearLayout.java:1552)
  at android.widget.LinearLayout.measureVertical (LinearLayout.java:842)
  at android.widget.LinearLayout.onMeasure (LinearLayout.java:721)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:194)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at androidx.coordinatorlayout.widget.CoordinatorLayout.onMeasureChild (CoordinatorLayout.java:804)
  at com.google.android.material.appbar.HeaderScrollingViewBehavior.onMeasureChild (HeaderScrollingViewBehavior.java:100)
  at androidx.coordinatorlayout.widget.CoordinatorLayout.onMeasure (CoordinatorLayout.java:875)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:194)
  at androidx.appcompat.widget.ContentFrameLayout.onMeasure (ContentFrameLayout.java:141)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at android.widget.LinearLayout.measureChildBeforeLayout (LinearLayout.java:1552)
  at android.widget.LinearLayout.measureVertical (LinearLayout.java:842)
  at android.widget.LinearLayout.onMeasure (LinearLayout.java:721)
  at androidx.appcompat.widget.FitWindowsLinearLayout.onMeasure (FitWindowsLinearLayout.java:7)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:194)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at android.widget.LinearLayout.measureChildBeforeLayout (LinearLayout.java:1552)
  at android.widget.LinearLayout.measureVertical (LinearLayout.java:842)
  at android.widget.LinearLayout.onMeasure (LinearLayout.java:721)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewGroup.measureChildWithMargins (ViewGroup.java:7951)
  at android.widget.FrameLayout.onMeasure (FrameLayout.java:194)
  at com.android.internal.policy.DecorView.onMeasure (DecorView.java:1173)
  at android.view.View.measure (View.java:27131)
  at android.view.ViewRootImpl.performMeasure (ViewRootImpl.java:4187)
  at android.view.ViewRootImpl.measureHierarchy (ViewRootImpl.java:2936)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:3204)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:2618)
  at android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:9971)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1010)
  at android.view.Choreographer.doCallbacks (Choreographer.java:809)
  at android.view.Choreographer.doFrame (Choreographer.java:744)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:995)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:246)
  at android.app.ActivityThread.main (ActivityThread.java:8633)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:602)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1130)
@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include OS/Android Fixes related to Android browser functionality feature/brave-news formerly brave-today labels May 13, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants