Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on permission window #38297

Closed
SergeyZhukovsky opened this issue May 13, 2024 · 2 comments · Fixed by brave/brave-core#23622
Closed

Crash on permission window #38297

SergeyZhukovsky opened this issue May 13, 2024 · 2 comments · Fixed by brave/brave-core#23622
Assignees
@SergeyZhukovsky
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release/blocking release-notes/exclude
Milestone
1.66.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented May 13, 2024 •
edited by kjozwiak

I found that crash on GPC on nightly and beta channels after we upgraded to chromium 125. I managed to replicate it as well.

Test Case #1

  1. Make sure that Widevine is turned off in Settings->Media.
  2. Open a website with Widevine content I used https://reference.dashif.org/dash.js/latest/samples/drm/widevine.html.
  3. Make sure you have a dialog with permission to turn on Widevine.
  4. Tap back button or swipe the dialog out.

Test Case #2

  1. Make sure that Widevine is turned off in Settings->Media.
  2. Open a website with Widevine content I used https://reference.dashif.org/dash.js/latest/samples/drm/widevine.html.
  3. Make sure you have a dialog with permission to turn on Widevine.
  4. tap on the "tab overview" button and close https://reference.dashif.org/dash.js/latest/samples/drm/widevine.html
  5. try opening a new tab and you'll notice Brave crashes

Examples of the above crashing can be found via brave/brave-core#23622 (comment).

Crash stack:


Stack Trace:                                                                                                                                                  
  RELADDR   FUNCTION                                                                          FILE:LINE
  v------>  base::ImmediateCrash()                                                            ../../base/immediate_crash.h:176:3       
  v------>  logging::CheckFailure()                                                           ../../base/check.h:212:3
  v------>  permissions::ContentSettingsTypeToRequestType_ChromiumImpl(content_settings::mojom::ContentSettingsType)  ../../../src/components/permissions/request_type.cc:271:3
  0000000004499dac  permissions::ContentSettingsTypeToRequestType(content_settings::mojom::ContentSettingsType)  ../../brave/chromium_src/components/permissions/request_type.cc:97:14
  0000000004495794  permissions::PermissionUmaUtil::RecordDismissalType(std::__Cr::vector<content_settings::mojom::ContentSettingsType, std::__Cr::allocator<content_settings::mojom::ContentSettingsType>> const&, permissions::PermissionPromptDisposition, permissions::DismissalType)  ../../../src/components/permissio
ns/permission_uma_util.cc:732:7
  v------>  permissions::PermissionDialogDelegate::Dismissed(_JNIEnv*, jni_zero::JavaParamRef<_jobject*> const&, int)  ../../../src/components/permissions/android/permission_prompt/permission_dialog_delegate.cc:209:3
  00000000044a3cf0  Java_J_N_My1ZBTOK                                                                 gen/jni_headers/components/permissions/android/jni_headers/PermissionDialogDelegate_jni.h:73:11
@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels May 13, 2024
@SergeyZhukovsky SergeyZhukovsky self-assigned this May 13, 2024
@SergeyZhukovsky SergeyZhukovsky mentioned this issue May 13, 2024
Merged
24 tasks
@SergeyZhukovsky SergeyZhukovsky mentioned this issue May 14, 2024
Open
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 14, 2024
This was referenced May 14, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.66.108 or higher for 1.66.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 15, 2024
@hffvld
Copy link
Contributor

hffvld commented May 15, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.66.107
Chromium: 125.0.6422.41 (Official Build) (64-bit)

STEPS:

  1. Follow the steps from Crash on permission window #38297 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Brave is not crashing
  • Verified that the user stays on the same page/tab when closing Widevine DRM dialog

Galaxy Tab S8

timestamp_13-11-26_13-11-56.mp4

Pixel 7

timestamp_12-43-03_12-44-04.mp4

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes a crash on Android permission dialog after cr125 update brave/brave-core
4 participants
@kjozwiak @SergeyZhukovsky @brave-builds @hffvld