Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad toolbar experience with Display Zoom, and implementing flag #brave-horizontal-tabs-update for iOS #37571

Closed
maxela-2001 opened this issue Apr 13, 2024 · 2 comments · Fixed by brave/brave-core#23618
Assignees
Labels
bug OS/iOS Fixes related to iOS browser functionality QA/No release-notes/include

Comments

@maxela-2001
Copy link

maxela-2001 commented Apr 13, 2024

Description:

Brave for iOS v1.61 has featured an updated design for the browser toolbar, as shown in the figma in #8379 from brave-ios.

While there are no visual bugs, some users may find the experience crippled compared to the previous design, especially if they turn on Display Zoom. In particular, the URL bar obstructs more screen real estate, and the paddings between icons can appear uncomfortably wide, in a way such that some users miss the previous design.

In other words...

I own an iPhone 13 mini. I turn on Display Zoom. It looks bad.

Not only it's no longer compact over Safari (one major preference when choosing Brave), I can barely read the URL in almost every case (See screenshots). It's possible that the redesign was hardly (or never?) tested with configurations like mine.

Proposed solution

On the desktop counterpart, the flag #brave-horizontal-tabs-update can be toggled to switch between old and new designs, but were not available for the iOS app (not listed in brave://flags accessed in v1.64 beta build, see #37149). Given this, I don't see why a similar flag that reverts to a previous design cannot be implemented in iOS as well.

Device details:

iPhone 13 mini (iOS 17.4)

Steps to Reproduce

  1. Go to iOS Settings > Display & Brightness > Display Zoom, set to Larger Text
  2. Open Brave and browse any webpage

Expected result:

At least the web address should be legible.

Actual result:

It does not.

Before v1.61 After v1.61
IMG_8519 IMG_8520
@kylehickinson
Copy link
Contributor

Marking as QA/No but if QA does have a iPhone mini model feel free to replace with QA/Yes and test

@maxela-2001
Copy link
Author

I am glad that the team has made progress, however there were more issues when porting the post 1.61 layout to smaller screens:

  • the paddings between icons can appear uncomfortably wide

  • the URL bar obstructs more screen real estate

The old layout before 1.61 was fine on small screens, and that's why a flag that reverts back to the old design would be beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/iOS Fixes related to iOS browser functionality QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@kylehickinson @brave-builds @maxela-2001 and others