Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Never Ask Again" under Google Translate popup #6340

Closed
kjozwiak opened this issue Oct 7, 2019 · 5 comments · Fixed by brave/brave-core#3617
Closed

Adding "Never Ask Again" under Google Translate popup #6340

kjozwiak opened this issue Oct 7, 2019 · 5 comments · Fixed by brave/brave-core#3617

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019

Description

When we released the Google Translate popup feature in 0.69.x via #5561, it made using Brave more inconvenient for none-english peaking users as they constantly get the popup when visiting English websites. Some examples of user concerns: #6326, #6329, #208 (comment), #208 (comment).

We should add a Never ask again or a Don't ask again checkbox under the prompt that would control the Offer to translate pages that aren't in a language you read setting via brave://settings/languages.

Steps to Reproduce

  1. install and launch 0.69.132 Chromium: 77.0.3865.90
  2. depending on your locale, visit a website that's in a different language so you get the Google Translate prompt.

Actual result:

Screen Shot 2019-10-07 at 1 06 18 PM

Expected result:

Should be similar to what we implemented with Widevine. Example:

Screen Shot 2019-10-07 at 12 38 27 AM

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @bbondy @davidtemkin @yrliou @brave/legacy_qa

@yrliou yrliou self-assigned this Oct 7, 2019
@rebron rebron added the design A design change, especially one which needs input from the design team label Oct 7, 2019
@rebron
Copy link
Collaborator

rebron commented Oct 7, 2019

@bradleyrichter @karenkliu Do we even need a mock? I think we can simply go with the:
[ ] Don't ask again
check box like what @kjozwiak linked to above.

@bradleyrichter
Copy link

2 options:

image

or

image

@karenkliu
Copy link

How about this:

install google translate

@yrliou
Copy link
Member

yrliou commented Oct 8, 2019

Test plan specified in brave/brave-core#3617 (comment).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 11, 2019

Verification passed on

Brave 0.69.134 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS Version 10.13.6 (Build 17G5019)

Verified passed with

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS Version 10.13.6 (Build 17G5019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants