Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Add Sponsored Images & Videos option to New Tab Page setting #38198

Closed
aseren opened this issue May 9, 2024 · 2 comments
Closed

[ads] Add Sponsored Images & Videos option to New Tab Page setting #38198

aseren opened this issue May 9, 2024 · 2 comments
Assignees
@aseren
Labels
closed/wontfix enhancement feature/ads OS/iOS Fixes related to iOS browser functionality
Projects
Ads

Comments

@aseren
Copy link

aseren commented May 9, 2024 •
edited by tmancey

We need to update Setting > New Tab Page as follows:

“Background Image” to “Background”

Image Type from
	Default Images
	Sponsored (Currently the default)
To
	Default Images
	Sponsored Images
	Sponsored Images & Videos (Make Default)
@aseren aseren added enhancement feature/ads OS/iOS Fixes related to iOS browser functionality labels May 9, 2024
@aseren aseren added this to New issues in Ads May 9, 2024
@tmancey tmancey moved this from New issues to Blocked in Ads May 10, 2024
@tmancey
Copy link
Contributor

tmancey commented May 10, 2024

Blocked because the CRX package would need updating to include both a static image and video.

@aseren aseren self-assigned this May 10, 2024
@aseren aseren moved this from Blocked to In progress in Ads May 10, 2024
@tmancey tmancey removed the blocked label May 10, 2024
@aseren aseren moved this from In progress to New issues in Ads May 10, 2024
@tmancey tmancey moved this from New issues to Q2/2024 Milestones & Showstoppers in Ads May 10, 2024
@aseren aseren moved this from Q2/2024 Milestones & Showstoppers to Priority in Ads May 15, 2024
@aseren aseren added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels May 15, 2024
@aseren aseren moved this from Priority to In progress in Ads May 28, 2024
@tmancey
Copy link
Contributor

tmancey commented Jun 3, 2024

Closing as out of scope, thanks

@tmancey tmancey closed this as completed Jun 3, 2024
Ads automation moved this from In progress to Done Jun 3, 2024
@tmancey tmancey added closed/wontfix and removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
closed/wontfix enhancement feature/ads OS/iOS Fixes related to iOS browser functionality
Projects
Ads
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @aseren