Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIChat: fix broken buttons #38157

Closed
nullhook opened this issue May 8, 2024 · 3 comments · Fixed by brave/brave-core#23505
Closed

AIChat: fix broken buttons #38157

nullhook opened this issue May 8, 2024 · 3 comments · Fixed by brave/brave-core#23505
Assignees
@nullhook
Labels
browser-ai bug OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.67.x - Beta

Comments

@nullhook
Copy link

nullhook commented May 8, 2024

this nala update broke plain-faint buttons on AIChat
@nullhook nullhook self-assigned this May 8, 2024
@nullhook nullhook mentioned this issue May 8, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 8, 2024
@stephendonner stephendonner mentioned this issue May 8, 2024
Closed
@stephendonner
Copy link

Example:

Screen Shot 2024-05-08 at 3 23 41 PM

@stephendonner
Copy link

stephendonner commented May 13, 2024 •
edited

Verified PASSED using

Brave | 1.67.82 Chromium: 125.0.6422.41 (Official Build) beta (x86_64)
-- | --
Revision | cbebefd4c702801af65a196ba9701a907ed0d292
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.67.82
  2. launched Brave
  3. loaded nbcnews.com
  4. clicked on Leo in the sidebar
  5. clicked on Summarize
  6. clicked I understand

Confirmed "slash tools" ([ / ] and (i) info bubble are displaying inline, correctly

Screen Shot 2024-05-13 at 3 25 01 PM

@stephendonner
Copy link

Verified PASSED using

Brave | 1.67.82 Chromium: 125.0.6422.41 (Official Build) beta (64-bit)
-- | --
Revision | cbebefd4c702801af65a196ba9701a907ed0d292
OS | Windows 10 Version 22H2 (Build 19045.4355)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
browser-ai bug OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
Browser AI
Status: Done
Milestone
1.67.x - Beta
Development

Successfully merging a pull request may close this issue.

aichat: update all plain-faint buttons brave/brave-core
3 participants
@stephendonner @nullhook @brave-builds