Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Commands]: Fix ampersand replacement #38113

Closed
fallaciousreasoning opened this issue May 7, 2024 · 3 comments · Fixed by brave/brave-core#23447
Closed

[Commands]: Fix ampersand replacement #38113

fallaciousreasoning opened this issue May 7, 2024 · 3 comments · Fixed by brave/brave-core#23447
Assignees
@fallaciousreasoning
Labels
OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.66.x - Release

Comments

@fallaciousreasoning
Copy link

Issue reported by @junkworld in #37905 (comment)
@fallaciousreasoning fallaciousreasoning self-assigned this May 7, 2024
@fallaciousreasoning fallaciousreasoning mentioned this issue May 7, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 7, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.67.73 Chromium: 125.0.6422.26 (正式版本) nightly （64 位）
-- | --
修订版本 | 76e7d97680074902ad7bde84f0a1a6c392a4ca6a
操作系统 | Windows 10 Version 22H2 (Build 19045.4355)

Steps:

  1. set OS region, language, etc. to Simplified Chinese
  2. installed 1.67.73
  3. launched Brave
  4. opened chrome://settings/system/shortcuts
  5. typed avascript
  6. examined all instances of matches

Confirmed all JavaScript entries began with J

image

@brave-builds brave-builds mentioned this issue May 7, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented May 8, 2024

The above requires 1.66.104 or higher for 1.66.x verification 👍 Removing the QA Pass label as the above will need to be re-verified using 1.66.x. However, used #38113 (comment) as the needed verification on Nightly before uplifting into 1.66.x as per brave/brave-core#23487 (review).

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 9, 2024
@LaurenWags
Copy link
Member

LaurenWags commented May 9, 2024 •
edited

Verified with

Brave | 1.66.104 Chromium: 125.0.6422.41 (Official Build) (x86_64)
-- | --
Revision | 6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS | macOS Version 13.6.6 (Build 22G630)

Reproduced the issue using 1.65.130.
Confirmed when using 1.66.104 entries displayed as expected.

1.65.103 1.66.104
1 65 1 66

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

[Commands]: Fix ampersand replacement brave/brave-core
5 participants
@stephendonner @kjozwiak @fallaciousreasoning @LaurenWags @brave-builds