Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Leave Sync Chain" and "Delete Sync account" more visibly separate #37903

Open
fmarier opened this issue Apr 27, 2024 · 3 comments
Open
Assignees
Labels
feature/sync OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include

Comments

@fmarier
Copy link
Member

fmarier commented Apr 27, 2024

We've had a report of a user who quickly clicked on "Leave Sync Chain" immediately after configuring the Sync data types, thinking that it was a save button: https://bravesoftware.slack.com/archives/C2HJYB45N/p1714163037164099

The "are you sure?" prompt didn't help since it was clicked through without reading.

Ideas for improvements include:

  • styling the dangerous buttons differently so that they don't look like "Add a new device"
  • making it clear to users that changes are saved immediately with a "Changes saved." kind of notice every time a toggle is clicked
  • adding a new heading (e.g. "Account Management" or "Danger Zone") so that the two dangerous buttons don't look like they are part of the data type selection heading
@fmarier fmarier added feature/sync design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop labels Apr 27, 2024
@aguscruiz
Copy link

I have an updated design here using the new style for settings, but should be easily translatable to current design.

For whoever works on this, let me know if you need me to mock up with the current design
https://www.figma.com/file/yX9HE8ltWeQsXwwjQJTECE/Sync-V3?type=design&node-id=835%3A14575&mode=design&t=qVwWEd0NDXAwnrAF-1

@fmarier
Copy link
Member Author

fmarier commented Apr 29, 2024

@aguscruiz That looks good.

I think it would be good to fix in SyncV2 if it's not too complicated. A SyncV2 mock would be useful.

@aguscruiz
Copy link

Sure, here's the design in V2 style. I just mocked the important part, not the whole sync page

https://www.figma.com/file/GXnHuBCVRY397UNJyvu44q/Sync-V2?type=design&node-id=483-1658&mode=design

@fmarier fmarier removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Apr 29, 2024
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include QA/Yes labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sync OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants