Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Ugly gradient on NTT video ad in Landscape mode #37894

Closed
btlechowski opened this issue Apr 26, 2024 · 1 comment
Closed

[ads] Ugly gradient on NTT video ad in Landscape mode #37894

btlechowski opened this issue Apr 26, 2024 · 1 comment
Assignees
Labels
bug closed/wontfix feature/ads OS/iOS Fixes related to iOS browser functionality
Projects

Comments

@btlechowski
Copy link

Follow up to #37653

Steps to Reproduce

  1. Fresh install
  2. Turn off WiFi and mobile network
  3. Launch browser
  4. Toggle Use Staging CRX components in Settings -> BraveCore Switches
  5. Set rewards to staging
  6. Close the browser
  7. Turn on WiFi or mobile network
  8. Launch Brave browser
  9. Launch browser in Portrait orientation
  10. Open New Tab Pages until a tab with New Tab Takeover video ad is opened
  11. Wait till video stops playing
  12. Rotate the phone to Landscape mode

Actual result:

Ugly gradient on NTT video ad in Landscape mode
Looks like we forgot to load a proper background image.

image

Expected result:

No ugly gradient on NTT video ad in Landscape mode

In landscape consider using the ad video keyframe and locking it to portrait (the keyframe image remains as in Portrait - it is not rotated)
So when user rotates the phone to portrait, the keyframe is already in portrait.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

1.67.44 on iphone 13 pro max

cc @tmancey @aseren

@btlechowski btlechowski added QA/Yes release-notes/exclude feature/ads OS/iOS Fixes related to iOS browser functionality labels Apr 26, 2024
@tmancey tmancey added this to New issues in Ads Apr 26, 2024
@aseren aseren moved this from New issues to Q2/2024 Milestones & Showstoppers in Ads Apr 30, 2024
@aseren aseren moved this from Q2/2024 Milestones & Showstoppers to New issues in Ads Apr 30, 2024
@tmancey
Copy link
Contributor

tmancey commented Apr 30, 2024

Closing as agreed we will not fix because if an RGB color is not specified in the filename the default is black #000000.

@tmancey tmancey closed this as completed Apr 30, 2024
Ads automation moved this from New issues to Done Apr 30, 2024
@tmancey tmancey self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/wontfix feature/ads OS/iOS Fixes related to iOS browser functionality
Projects
Ads
  
Done
Development

No branches or pull requests

2 participants