Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Crash in brave_ads::TabManager::OnNotifyTabHtmlContentDidChange #37181

Closed
tmancey opened this issue Mar 28, 2024 · 1 comment · Fixed by brave/brave-core#22842
Closed

[ads] Crash in brave_ads::TabManager::OnNotifyTabHtmlContentDidChange #37181

tmancey opened this issue Mar 28, 2024 · 1 comment · Fixed by brave/brave-core#22842
Assignees
@tmancey
Labels
crash feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Milestone
1.66.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 28, 2024 •
edited 

[ 00 ] base::ImmediateCrash() ( immediate_crash.h:176 )
[ 01 ] logging::CheckFailure() ( check.h:211 )
[ 02 ] brave_ads::TabManager::OnNotifyTabHtmlContentDidChange(int, std::__Cr::vector<GURL, std::__Cr::allocator<GURL>> const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) ( tab_manager.cc:158 )
[ 03 ] brave_ads::AdsClientNotifier::NotifyTabHtmlContentDidChange(int, std::__Cr::vector<GURL, std::__Cr::allocator<GURL>> const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) const ( ads_client_notifier.cc:147 )
[ 04 ] bat_ads::mojom::BatAdsClientNotifierStubDispatch::Accept(bat_ads::mojom::BatAdsClientNotifier*, mojo::Message*) ( bat_ads.mojom.cc:1969 )
[ 05 ] mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ( interface_endpoint_client.cc:1021 )
[ 06 ] mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*) ( interface_endpoint_client.cc:368 )
[ 07 ] mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ( interface_endpoint_client.cc:1021 )
[ 08 ] mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*) ( interface_endpoint_client.cc:368 )
[ 09 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ( message_dispatcher.cc:43 )
[ 10 ] mojo::internal::MultiplexRouter::Accept(mojo::Message*) ( multiplex_router.cc:710 )
[ 11 ] mojo::MessageDispatcher::Accept(mojo::Message*) ( message_dispatcher.cc:43 )
[ 12 ] void base::internal::DecayedFunctorTraits<void (mojo::Connector::*)(char const*, unsigned int), mojo::Connector*, char const* const&>::Invoke<void (mojo::Connector::*)(char const*, unsigned int), mojo::Connector*, char const*, unsigned int>(void (mojo::Connector::*)(char const*, unsigned int), mojo::Connector*&&, char const*&&, unsigned int&&) ( connector.cc:554 )
@tmancey tmancey added crash priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Mar 28, 2024
@tmancey tmancey self-assigned this Mar 28, 2024
@tmancey tmancey added this to Review in Ads Mar 28, 2024
@tmancey tmancey mentioned this issue Mar 28, 2024
Merged
24 tasks
Ads automation moved this from Review to Done Mar 28, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 28, 2024
@btlechowski
Copy link

Verified with

Brave 1.66.91 Chromium: 124.0.6367.91 (Official Build) beta (64-bit)
Revision 5c30ebba7e5e93df8fbf633585986e5e907d07e8
OS Linux

Verified no crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
crash feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
  
Done
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

[ads] Fixes crash in brave_ads::TabManager::OnNotifyTabHtmlContentDidChange brave/brave-core
3 participants
@tmancey @btlechowski @brave-builds