Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Rename kViewed and kServed to kViewedImpression and kServedImpression #37132

Closed
tmancey opened this issue Mar 27, 2024 · 1 comment · Fixed by brave/brave-core#22807
Closed

[ads] Rename kViewed and kServed to kViewedImpression and kServedImpression #37132

tmancey opened this issue Mar 27, 2024 · 1 comment · Fixed by brave/brave-core#22807
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Milestone
1.66.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 27, 2024

No description provided.

@tmancey tmancey self-assigned this Mar 27, 2024
@tmancey tmancey added this to Review in Ads Mar 27, 2024
@tmancey tmancey mentioned this issue Mar 27, 2024
Merged
24 tasks
Ads automation moved this from Review to Done Mar 28, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 28, 2024
@btlechowski
Copy link

Verified with

Brave 1.66.91 Chromium: 124.0.6367.91 (Official Build) beta (64-bit)
Revision 5c30ebba7e5e93df8fbf633585986e5e907d07e8
OS Linux

Verified kServedImpression is used

[11506:11506:0428/194944.210466:VERBOSE1:new_tab_page_ad_event_handler.cc(144)] Failed to fire new tab page ad kServedImpression event for placement id 5347f663-c85f-4525-a790-e2048de39238 and creative instance id c1bbef73-5201-4ccd-9ed0-d897610d6a0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
  
Done
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

[ads] Rename kViewed and kServed to kViewedImpression and kServedImpression brave/brave-core
3 participants
@tmancey @btlechowski @brave-builds