Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leo - AI Title - Icon + Text stacking #36870

Closed
aguscruiz opened this issue Mar 17, 2024 · 2 comments · Fixed by brave/brave-core#23129
Closed

Leo - AI Title - Icon + Text stacking #36870

aguscruiz opened this issue Mar 17, 2024 · 2 comments · Fixed by brave/brave-core#23129

Comments

@aguscruiz
Copy link

Description:

The intro text for each AI model should be stacked with the icon, instead of them being side by side.

Steps to Reproduce

  1. Open Leo on iOS
  2. See first intro card

Actual result:

image

Expected result:

Design
https://www.figma.com/file/h7fKSJF2P556bZWfyLTfwD/Leo-MVP?type=design&node-id=6511%3A108804&mode=design&t=rDHbigSNNb6UsjCo-1

image

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

@kjozwiak
Copy link
Member

kjozwiak commented May 2, 2024

The above requires 1.65.128 or higher for 1.65.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 14, 2024
@hffvld
Copy link
Contributor

hffvld commented May 15, 2024

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.5
- iPad Air / iPadOS 16.7.2
Brave build: 1.66 (108)
BraveCore: 1.66.108 (125.0.6422.41)

STEPS:

  1. Launch Brave
  2. Open Leo > Verfiy

ACTUAL RESULTS:

  • Verified that the intro text for any AI model is stacked with the icon, instead of being side by side
  • Verified the same in Portrait & Landscape modes and Dark & Light themes

iPhone 14
1 2
1 2
1 2
iPad Air
1 2
1 2
1 2

@hffvld hffvld added QA Pass-iPhone QA/Test-All-Platforms QA Pass-iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment