Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Use page context for response tooltip experience/tap radius #35989

Closed
kjozwiak opened this issue Feb 12, 2024 · 0 comments · Fixed by brave/brave-core#23460
Closed

improve Use page context for response tooltip experience/tap radius #35989

kjozwiak opened this issue Feb 12, 2024 · 0 comments · Fixed by brave/brave-core#23460
Assignees
Labels
browser-ai bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 12, 2024

Description

We should probably improve the overall experience of attempting to tap/interact with the Use page context for response (!) tooltip. The tap radius seems to be pretty small and there's cases where you'll enable/disable the feature rather than actually seeing the tooltip due to the radius being small. There's also times when I initially pull up Leo, tapping the ! area expands Leo to full screen rather than displaying the tooltip.

I guess the above is also related to brave/brave-core#21945 which gave users the ability to view the tooltip by tapping/holding on the ! button.

Steps to reproduce

  1. install/launch 1.64.65 Chromium: 122.0.6261.29
  2. visit any website and within the Hamburger Menu, select Leo
  3. once Leo is displayed/visible, attempt to tap/hold the ! button to the right of Use page context for response

Run through the above a few times re: attempting to tap/hold the ! button and you'll notice it becomes challenging at times.

Actual result

screen-20240212-172116.mp4

Expected result

Should make the experience a bit easier re: tapping/hold ! to view the tooltip/information on what the setting does.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A (Leo being released via 1.63.x)
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 8 Pro
  • Android version: Android 14

Brave version

Brave | 1.64.65 Chromium: 122.0.6261.29 (Official Build) canary (64-bit)
--- | ----
Revision | a31a4290998445a19f5f22b803256e97ec3036a5
OS | Android 14; Build/UQ1A.240105.004; 34; REL

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @SergeyZhukovsky @hffvld @Uni-verse

@kjozwiak kjozwiak added bug QA/Yes OS/Android Fixes related to Android browser functionality browser-ai labels Feb 12, 2024
@kjozwiak kjozwiak changed the title improve Use page context for response tooltip experience/tap radios improve Use page context for response tooltip experience/tap radius Feb 12, 2024
@mattmcalister mattmcalister added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 23, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 9, 2024
@nullhook nullhook self-assigned this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants