Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Binance Smart Chain to BNB Smart Chain #29110

Closed
onyb opened this issue Mar 16, 2023 · 3 comments · Fixed by brave/brave-core#23392
Closed

Rename Binance Smart Chain to BNB Smart Chain #29110

onyb opened this issue Mar 16, 2023 · 3 comments · Fixed by brave/brave-core#23392
Assignees
@josheleonard
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.67.x - Beta

Comments

@onyb
Copy link
Member

onyb commented Mar 16, 2023

News regarding the rebranding: https://www.coindesk.com/business/2022/02/15/binance-smart-chain-rebrands-to-bnb-chain/
@jamesmudgett jamesmudgett changed the title Rename Binance Smart Chain to BNB Smart Chain Rename Binance Smart Chain to BNB Chain Mar 17, 2023
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Mar 17, 2023
@onyb onyb changed the title Rename Binance Smart Chain to BNB Chain Rename Binance Smart Chain to BNB Smart Chain Mar 17, 2023
@onyb
Copy link
Member Author

onyb commented Mar 17, 2023

The name should be BNB Smart Chain and not BNB Chain, which is like a meta name for BSC + Binance Chain.

Screenshot 2023-03-17 at 23 09 46

@vednp
Copy link

vednp commented Mar 24, 2023

Hey @onyb I would like to do this can you assign it to me?

@josheleonard josheleonard self-assigned this May 2, 2024
@josheleonard josheleonard mentioned this issue May 2, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 6, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.67.83 Chromium: 125.0.6422.41 (Official Build) beta (64-bit)
Revision d80b776d8894973bb67aab6b82202fd332da33c7
OS Windows 11 Version 23H2 (Build 22631.3527)
  • Verified steps from brave/brave-core#23392
  • Verified Binance Smart Chain is now remaned to BNB Smart Chain through out the wallet
29110.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.67.x - Beta
Development

Successfully merging a pull request may close this issue.

fix(wallet): rename Binance Smart Chain to BNB Smart Chain brave/brave-core
6 participants
@jamesmudgett @onyb @srirambv @josheleonard @brave-builds @vednp