Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preloaded MP4 files cannot be imported via IPFS context menu #16705

Closed
GeetaSarvadnya opened this issue Jun 30, 2021 · 4 comments · Fixed by brave/brave-core#9339
Closed

Preloaded MP4 files cannot be imported via IPFS context menu #16705

GeetaSarvadnya opened this issue Jun 30, 2021 · 4 comments · Fixed by brave/brave-core#9339

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 30, 2021

Description

Found while testing #15937
Preloaded MP4 files cannot be imported via IPFS context menu

Steps to Reproduce

  1. Clean profile 1.27.x
  2. Enable IPFS
  3. Use the Ctlr+O shortcut key and open any MP4 file from your local machine
  4. Right-click on the play icon and select Import to IPFS->Selected video option
  5. Getting IPFS import failed

Actual result:

IPFS import failed for MP4 files
IPFS import failed

image

Expected result:

Should be able to import MP4 files

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.27.84 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Windows 10 OS Version 2004 (Build 19041.1052)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @spylogsster @brave/legacy_qa @rebron

@stephendonner
Copy link

Thanks, @GeetaSarvadnya - FWIW, I've also reproduced this on:

Brave 1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS Version 11.4 (Build 20F71)

File: https://download.samplelib.com/mp4/sample-5s.mp4 from https://samplelib.com/sample-mp4.html

@stephendonner
Copy link

This worked for me, same build as above, when I ran with --use-dev-goupdater-url, and picked up go-ipfs 0.9.0 (which we are set to release today or tomorrow). Does that fix it for you, @GeetaSarvadnya ?

@GeetaSarvadnya
Copy link
Author

@stephendonner It's not working for me in IPFS version 0.9.0
IPFS_MP4 Import failed

@spylogsster spylogsster moved this from Untriaged to Backlog in IPFS Jul 2, 2021
@spylogsster spylogsster moved this from Backlog to In Progress in IPFS Jul 5, 2021
@spylogsster spylogsster self-assigned this Jul 5, 2021
@spylogsster spylogsster moved this from In Progress to In Review in IPFS Jul 5, 2021
IPFS automation moved this from In Review to Done Jul 7, 2021
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 7, 2021
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jul 15, 2021

Verification passed on


Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | Windows 10 OS Version 2004 (Build 19041.1083)

  • Verified the STR from the description and ensured .MP4 files can be imported via IPFS context menu
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment