Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported Linked content is not showing up in the ipfs localhost #16680

Closed
GeetaSarvadnya opened this issue Jun 29, 2021 · 5 comments
Closed

Imported Linked content is not showing up in the ipfs localhost #16680

GeetaSarvadnya opened this issue Jun 29, 2021 · 5 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 29, 2021

Description

Found while testing #15937
Imported Linked content is not showing up in the ipfs localhost

Steps to Reproduce

  1. Clean profile 1.27.x
  2. Enable ipfs and open blog. brave.com
  3. Import a linked content
  4. Imported Linked content is not showing up in the ipfs localhost

Actual result:

image
image

Expected result:

linked content should be shown instead of object object

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.27.84 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Windows 10 OS Version 2004 (Build 19041.1052)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @spylogsster

@lidel
Copy link

lidel commented Jun 30, 2021

This is caused by a bug in ipfs-webui.
It was fixed in latest version shipped with go-ipfs 0.9.0, so only thing here is to retest after we update to go-ipfs 0.9

@spylogsster
Copy link

lets check this after brave/qa-resources#321

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 30, 2021

Please note the issue applicable for import This page and Selected text context menus also.

This page
image
image

Selected text
image
image

@stephendonner
Copy link

@GeetaSarvadnya mind double-checking if this is fixed with the latest go-ipfs 0.10.0-rc1 release (or later) when you get a chance? Thanks!

@GeetaSarvadnya
Copy link
Author

Verification PASSED on

Brave | 1.34.80 Chromium: 97.0.4692.71 (Official Build) (64-bit)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Windows 10 Version 21H2 (Build 19044.1415)

  • Confirmed that import Linked content, This page and Selected text context menus are working as expected, click on any of the imported files opens up the content of the imported file.

IPFS Linked content import

IPFS automation moved this from LocalNode to Done Jan 10, 2022
@GeetaSarvadnya GeetaSarvadnya added this to the 1.34.x - Release milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
IPFS
  
Done
Development

No branches or pull requests

4 participants