Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable local node for iOS #16267

Closed
spylogsster opened this issue Jun 7, 2021 · 3 comments · Fixed by brave/brave-core#9058
Closed

Disable local node for iOS #16267

spylogsster opened this issue Jun 7, 2021 · 3 comments · Fixed by brave/brave-core#9058

Comments

@spylogsster
Copy link

spylogsster commented Jun 7, 2021

Disable local node for iOS, use only gateway there
Maybe add something like ipfs_local_node_enabled = !ios

##Test Plan

  • Check IPFS features work as extected for Desktop/Mobile
@spylogsster spylogsster added OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Jun 7, 2021
@spylogsster spylogsster self-assigned this Jun 7, 2021
@spylogsster spylogsster added this to Untriaged in IPFS via automation Jun 7, 2021
@spylogsster spylogsster moved this from Untriaged to In Progress in IPFS Jun 7, 2021
IPFS automation moved this from In Progress to Done Jun 10, 2021
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 10, 2021
@stephendonner
Copy link

stephendonner commented Jul 2, 2021

Verified PASSED using the in-progress regression-testplan over at https://github.com/brave/brave-browser/wiki/IPFS-Features with build

Brave 1.27.88 Chromium: 91.0.4472.124 (Official Build) dev (x86_64)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS Version 11.4 (Build 20F71)

and tested using the released-today go-ipfs 0.9.0 binary.


Verified PASSED using go-ipfs 0.9.0 with

Brave 1.27.91 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Linux

Verification passed on

Brave | 1.27.87 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
-- | --
Revision | 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS | Windows 10 OS Version 2004 (Build 19041.1052)

Importing selected video

.mp4
image

.webm
image

Sharing a local file using IPFS (without keys)
  • Confirmed the following file types can be shared using IPFS via +Import and hamburger menu IPFS->Share local file using IPFS
  • Confirmed the files .txt, .json, .ogg and .wav can be viewed in IPFS
  • .avi, .mpeg files cannot be played via IPFS import - Logged .avi, .mpeg files cannot be played via IPFS import #16752

.txt
image

.json
image

.ogg
image

.wav
image

Importing selected image
  • Confirmed the selected image on webpage is downloaded and imported
  • Confirmed import folder is opened when import completed successfully
  • Confirmed the imported image can be downloaded successfully
  • Confirmed the shareable link is copied to the clipboard and opens when pasting it in the URL bar
Example Example Example Example Example
image image image image image
Sharing a local folder using IPFS (without keys)
  • Confirmed local folders can be imported via IPFS -> share Local Folder Using IPFS ( from hamburger menu)
  • Confirmed whole folder is imported successfully
  • Confirmed the import folder is opened when import completed successfully
  • Confirmed files can be downloaded and the downloaded one is the same as original
  • Confirmed the shareable link is copied to the clipboard.
Example Example Example Example Example Example
image image image image image image

Logged #16758 - .PNG and .JPG files cannot be viewed via IPFS import
Additional testing is covered in #15937 (comment)

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 2, 2021
@stephendonner
Copy link

@spylogsster can you help us get a more-specific test plan which works for iOS? I'd like to get it incorporated into https://github.com/brave/brave-browser/wiki/IPFS-Features; thanks!

@spylogsster
Copy link
Author

afaik it is not implemented for iOS yet, in this issue just need to check that overall ipfs works on desktop and android via localnode as usual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment