Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ipns://<.crypto or .eth> by default when IPFS is setup #15749

Open
bbondy opened this issue May 11, 2021 · 5 comments
Open

Use ipns://<.crypto or .eth> by default when IPFS is setup #15749

bbondy opened this issue May 11, 2021 · 5 comments
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects

Comments

@bbondy
Copy link
Member

bbondy commented May 11, 2021

For our Unstoppable Domains and ENS we're currently resolving to HTTP. We should prefer to resolve to IPFS first by simply loading ipns:// as the default protocol for them when IPFS is setup.

Screen Shot 2021-05-11 at 10 17 04 AM

go-ipfs will support this in 0.9.0 so we can wait for the RC1 to be released and then use an RC manually before we ship the update to implement this.

Note that we shouldn't use this ipns:// method when the option mentioned in this issue is set to Ethereum:
#15750

@bbondy bbondy added this to Untriaged in Wallet via automation May 11, 2021
@bbondy bbondy added this to Untriaged in IPFS via automation May 11, 2021
@bbondy bbondy changed the title Prefer DNSLink when possible for Unstoppable Domains and ENS Use ipns://<.crypto or .eth> by default when IPFS is setup May 11, 2021
@lidel
Copy link

lidel commented May 11, 2021

@bbondy bbondy moved this from Untriaged to Brave Wallet Backlog in Wallet May 14, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 14, 2021
@spylogsster
Copy link

waiting for 0.9.0 for this #15937

@spylogsster spylogsster moved this from Untriaged to Icebox in IPFS May 24, 2021
@bbondy
Copy link
Member Author

bbondy commented Jul 21, 2021

Just checking on the status of this since 0.9.0 is shipped.

@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 21, 2021
@lidel
Copy link

lidel commented Jul 27, 2021

afaik this is ready to be picked up and worked on – go-ipfs 0.9+ already shipped to all users, so we can have ipns://*.eth in address bar and control which DoH endpoint is used for resolving them via DNS.Resolvers in $IPFS_PATH/config

@bbondy bbondy moved this from Backlog to Needs more info in Wallet Nov 3, 2021
@bbondy bbondy moved this from Needs more info to Backlog in Wallet Nov 3, 2021
@bbondy bbondy removed this from Backlog in Wallet Mar 18, 2022
@spylogsster spylogsster removed their assignment Jun 24, 2022
@gerbz
Copy link

gerbz commented Aug 22, 2022

@bbondy Would love to see ENS domains defaulting to ipns:// which leaves the .eth name in the address bar. This also makes the .eth name accessible via javascript window.location.hostname.

You can use Vitalki's as an example as vitalik.eth's ENS Content record is set with an ipfs:// key.
esteroids uses an ipns:// key in their esteroids.eth ENS Content record and it appears to behave the same way as Vitalik's in Brave.

Brave Settings -> Method to resolve IPFS resources -> Local IPFS Node:

  • ✅ ipns://vitalik.eth -> ipns://vitalik.eth
  • ❌ vitalik.eth -> ipfs://bafybeibc7nsbhktzjvplpi4qmzk7kd22yqol3v4thpbhp5yzfspcc56hsi/

Brave Settings -> Method to resolve IPFS resources -> Gateway:

@lidel and @makoto may have some input/insights on this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
IPFS
  
Icebox
Status: Backlog
Development

No branches or pull requests

4 participants