Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Conversion URLs must be the same eTLD+1 as Creative target URL #741

Open
iambrianfung opened this issue Apr 24, 2023 · 3 comments
Assignees

Comments

@iambrianfung
Copy link
Collaborator

If Conversion URL is provided, check that it is the same eTLD+1 as the target URL of the creatives provided.
If not, reject the Conversion URL and inform the user.

@IanKrieger
Copy link
Member

@iambrianfung this would assume that all creatives also have the same eTLD+1, is this an expectation as well?

@iambrianfung
Copy link
Collaborator Author

iambrianfung commented Apr 24, 2023

yes, that would be the expectation
cc: @murphyd to keep me honest

@murphyd
Copy link
Member

murphyd commented Jan 19, 2024

The expectation here would be:

  1. the creatives would match the same eTLD+1
  2. There should be a larger discussion around conversion URLs. Not all advertisers use the same domain for a conversion URL. For example, some have used a conversion URL located on https://chromewebstore.google.com/, others may use social channels, etc. as a conversion URL.

There also seems to be a similar issue here: https://github.com/brave/ads-admin-dashboard/issues/536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants