Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Brave's ad-block's region_list is not as complete as uBO's #146

Open
rht opened this issue Dec 3, 2018 · 9 comments
Open

Brave's ad-block's region_list is not as complete as uBO's #146

rht opened this issue Dec 3, 2018 · 9 comments

Comments

@rht
Copy link
Contributor

rht commented Dec 3, 2018

Missing regions are NOR, ROU, POR, and THA.

@krystian3w
Copy link

krystian3w commented Feb 29, 2020

@pes10k
Copy link
Collaborator

pes10k commented Feb 29, 2020

I defer to @ryanbr if we should pull in new lists. If he says so, this is 👍 from me.

@ryanbr what do you think?

@ryanbr
Copy link

ryanbr commented Mar 1, 2020

Okay, will look through these lists. Some are very specific to uBO (which won't work in Brave Release)

@ryanbr
Copy link

ryanbr commented Mar 2, 2020

I don't see an issue with it, though applying possibly all separate Anti-adblock lists for all languages would make brave://adblock much larger (which may need to reorganise if got too large). But as its stands, it's fine to include. I can patch this in this week.

@pes10k
Copy link
Collaborator

pes10k commented Mar 2, 2020

@ryanbr sounds good! If you need any help handling, let me know. Also, @bbondy , is it alright ot add these additional languages in?

@bbondy
Copy link
Member

bbondy commented Mar 2, 2020

you can go ahead and add more languages 👍

@pes10k
Copy link
Collaborator

pes10k commented Mar 2, 2020

terrific! @ryanbr if you need any help with this let me know. Otherwise, looks like you're good to go!

@krystian3w
Copy link

Also see this: brave/adblock-lists#334

Prebake is unsupported (the repository has been archived and has not been updated for several years), no block many cookies bars / popups and possible generate breakge.

https://github.com/brave/ad-block/blob/0a03587e37990ea5c22abca798d8c63da06bf3e3/lists/regions.h#L88

@ryanbr
Copy link

ryanbr commented Mar 4, 2020

@krystian3w Yeah, we're aware of it. brave/adblock-rust#67 (WIP)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants