Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Left anchor filters do not support wildcards #136

Open
bbondy opened this issue Oct 22, 2018 · 5 comments
Open

Left anchor filters do not support wildcards #136

bbondy opened this issue Oct 22, 2018 · 5 comments

Comments

@bbondy
Copy link
Member

bbondy commented Oct 22, 2018

Currently left anchored filters only support exact matches.
Should they support wildcards? There are some easylist rules (a few) which do that.

@bjb568
Copy link

bjb568 commented May 31, 2019

An example from EazyPrivacy is ||fls-*.amazon.*%1 which should be matched by this URL:

https://fls-na.amazon.com/1/action-impressions/1/OE/aws-mktg/action/awsm_v2_:perf_windowLoad@v=1815:u=ms/awsm_v2_:perf_loadEventEnd@v=1805:u=ms/awsm_v2_:perf_domComplete@v=1791:u=ms?dataset=LIVE%3APROD&instance=LIVE&service=awsm&marketplace=en_US&client=dsk&host=aws.amazon.com&marketplaceId=A12QK8IU0H0XW5&requestId=ABCDEFGHIJKLMNOPQRST&session=123-1234567-1234567

(I'm working with @snyderp this summer.)

@pes10k
Copy link
Collaborator

pes10k commented Jun 5, 2019

I think there might have been a copy-paste error in the above. The filter rule is ||fls-*.amazon.*% (no trailing 1

@bbondy
Copy link
Member Author

bbondy commented Jun 5, 2019

oh I think there is just no wildcards in the host supported. But that seems like a different issue than the left anchored filters

@bbondy
Copy link
Member Author

bbondy commented Jun 5, 2019

This repo is basically deprecated though in favour of brave/adblock-rust

@pes10k
Copy link
Collaborator

pes10k commented Jun 5, 2019

Thanks @bbondy. Working with @AndriusA to get this parsed right in the new one. Will focus attention there going forward.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants