-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-certificate to also check "additional names"? #55
Comments
@mvberg Thanks! Hmm… 🤔 So the way I designed it is when the certificate gets created, the primary domain name is whatever you put as the domain in your configuration (e.g. Or is the issue that you already have a certificate that was manually created, and what you’re using as the domain name doesn’t match the primary domain on the certificate, but it is in the “additional names”? |
exactly this. i have a "wildcard" certificate that i would like to reuse. but thinking about this again, what about adding an option to set the certificate ARN in the module.exports = {
title: "Create certificate",
skip: async (context) => {
let domain = context.config.domain
if (context.config.certificate_arn) { // existing certificate
context.certificateARN = context.config.certificate_arn;
return "Using Certificate from config"
} |
Before I shipped Discharge I waffled back and forth about wether or not to expose configuration options for declaring the IDs of certain, possibly existing resources, like a certificate or distribution. Ultimately I decided not to, in part because it wouldn’t be necessary most of the time, but also because I’m generally allergic to adding options like this unless absolutely necessary—I prefer convention over configuration. I think there might be a good way to solve this, though, without configuration, I’m just not sure I have all the right information yet. For your existing certificate, can you tell me exactly what the values of Thanks! |
v nice lib - thank you @brandonweiss
it would be nice to have
create-certificate
also check "Additional names" in addition to theDomainName
similar to how
create-distribution
checks onAliases
use case: i would like to reuse the same certificate across my
dev.*
,stage.*
andwww.*
environments (rather than having to configure certificates for each env)i can send a PR if you would consider this behavior.
cheers.
The text was updated successfully, but these errors were encountered: